Merged
Conversation
This commit modifies build_nhf.py so that it overwrites instead of purges existing tables. This allows rollbacks/keeps previous versions in the catalog
Previously build_nhf.py always assumed it would add NHF tables to the test environment. This makes it possible to use build_nhf.py to update OE nhf tables
quercoak
approved these changes
Apr 3, 2026
.pyiceberg.yaml
Outdated
| s3.endpoint: s3.us-east-1.amazonaws.com | ||
| warehouse: s3://52fcde3e7-5582-477d-7686ou4ij1ptxj8equ83a5xc51fsuse1b--table-s3 | ||
| # warehouse: s3://52fcde3e7-5582-477d-7686ou4ij1ptxj8equ83a5xc51fsuse1b--table-s3 # Test | ||
| warehouse: 154735606025 # OE |
There was a problem hiding this comment.
I think we'd rather leave this commited to test
|
Ran the updated subsetter for gage 12175500 which was previously missing the waterbodies layer. The geopackage now contains the waterbodies layer. Code changes for the subsetter and other items look good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the API and icefabric hydrofabric schemas to be able to handle the oCONUS domains. It also modifies the script that builds the NHF so that when tables are written to a given environment you can overwrite the existing tables and update the table schema instead of having to purge the tables. Finally this PR modifies the NHF subsetting so that the gpkg returned by the subsetter always returns all the NHF layers even if some of the layers are empty.