fix: modify crosswalk script to use full schism mesh#75
Merged
Conversation
The original icefabric crosswalk tool script extracted centroids from previously crosswalked schism mesh elements. The new tool is designed to work with schism meshes directly and doesn't need an upstream crosswalk file.
Previously flowpaths crossing schism boundary were only being crosswalked to the mesh if the crossing happened in the downstream part of the flowpath. This was leading to some crossings not being crosswalked.
quercoak
approved these changes
Mar 31, 2026
quercoak
left a comment
quercoak
left a comment
There was a problem hiding this comment.
Ran code. Output and logic look good. Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original icefabric crosswalk tool script extracted centroids from previously crosswalked schism mesh elements. The new tool is designed to work with schism meshes directly and doesn't need an upstream crosswalk file.
This tool finds locations where NHF flowpaths cross the mesh boundary and then uses the SCHISM mesh element closest to the crossing to assign a crosswalk point.
Below you can see the boundary line in green, flowpaths in blue, and nexuses in grey. The cross-walked points are blue points that are assigned to a divide where a flowpath crosses the boundary.