adding kernel links, displaying documentation urls, tooltips#16
adding kernel links, displaying documentation urls, tooltips#16aizazkhan1998 wants to merge 2 commits intomainfrom
Conversation
aseeland
left a comment
aseeland
left a comment
There was a problem hiding this comment.
In the first round I only looked over the kernels_and_extensions- links feature. I will do the other ones, when we are finished here.
By the way, you only linked kernels so far - what about the jupyter extensions?
data/kernels_and_extensions.yml
Outdated
| Octave: https://github.com/Calysto/octave_kernel | ||
| Sage: https://github.com/sagemath/sage | ||
| gnuplot: https://github.com/has2k1/gnuplot_kernel | ||
| Mathematica: https://github.com/WolframResearch/WolframLanguageForJupyter |
There was a problem hiding this comment.
This one https://github.com/mmatera/iwolfram seems more likely to me to be the correct one. However I am not completely sure. Can you list the instances that name Mathematica kernel?
There was a problem hiding this comment.
Updated the URL
University of Münster > Mathematica
There was a problem hiding this comment.
Hi @miwig : can you maybe confirm, that https://github.com/mmatera/iwolfram is the kernel that Münster's Jupyterhub uses for Mathematica?
include/details.md
Outdated
| {% if features.programming_languages %} | ||
| Programming Languages: | ||
| {% for kernel in features.programming_languages %} | ||
| {% if Links[kernel] %} |
There was a problem hiding this comment.
This will only work if the key in kernels_and_extensions.yaml matches exactly the word, people put in the data.yaml file. What about handling different capitalization? Versions at the end? You have to handle that here.
There was a problem hiding this comment.
Will remove the versions and as stated previously would " | lower" to change user input to lower case and have the keys lowered as well.
There was a problem hiding this comment.
Can not see any code that removes the version... do I miss something?
|
|
||
| {% if technicals %} | ||
| ## Technicals | ||
| ## Technical |
There was a problem hiding this comment.
Is the 's' wrong, when talking about several technical facts? If yes, we have to also rename the variable...
There was a problem hiding this comment.
Both are correct, there is a differnce of tone however. Technicals is unconventional and informal while technical is more formal.
aseeland
left a comment
aseeland
left a comment
There was a problem hiding this comment.
You didn't comment so far to:
By the way, you only linked kernels so far - what about the jupyter extensions?
Can you?
| matlab 2020b: https://www.mathworks.com/content/dam/mathworks/mathworks-dot-com/support/sysreq/files/system-requirements-release-2020b-linux.pdf | ||
| matlab 2022b: https://www.mathworks.com/content/dam/mathworks/mathworks-dot-com/support/sysreq/files/system-requirements-release-2022b-windows.pdf |
There was a problem hiding this comment.
These are no links to Jupyter kernels. And we have the reference in line 22. So you can remove the matlab links here.
| - {{ kernel }} {% if Links[kernel] %} [{{ Links[kernel] }}]({{ Links[kernel] }}) | ||
| {% else %} | ||
| {% endif %} |
There was a problem hiding this comment.
Compare to if else loop of features.programming_language. The else-part contains nothing at the moment...
| - macros: | ||
| include_dir: include | ||
| include_yaml: | ||
| - data/kernels_and_extensions.yml |
There was a problem hiding this comment.
Shouldn't this be "kernels_and_extensions.yaml"?
2 participants
No description provided.