Conversation
fix libssh2 import lib name for windows build handle libssh2 or ssh2 libraries Remove clang compiler settings from build workflow Update build workflow to specify C and C++ compilers for Windows build Refactor CMakeLists.txt to conditionally apply compiler options for non-MSVC builds Refactor type casting in Git-related classes for consistency and clarity clang style fix Add NOMINMAX definition for Windows compatibility and adjust exception filter declaration Skip wincred helper for MSVC builds in CMakeLists.txt to ensure compatibility with cl.exe
… for improved performance
|
Thank you very much! |
.github/workflows/build.yml
Outdated
| cd build/release | ||
| cmake -G Ninja -DCMAKE_BUILD_TYPE=Release -DUPDATE_TRANSLATIONS=ON -DGITTYUP_CI_TESTS=ON ${{ env.CMAKE_FLAGS }} ${{ matrix.env.cmake_flags }} ../.. | ||
|
|
||
| - name: Fix libssh2 import lib name (Windows) |
There was a problem hiding this comment.
Is it possible to do this directly in cmake?
There was a problem hiding this comment.
Good call.. certainly makes more sense in cmake. First pass I was trying to get it working and I find it easier to think about this type of change in build as my brain doesn't like to parse makefiles ;-)
Took a shot at it, build action running on my personal repo now.
There was a problem hiding this comment.
After revision build passed. How's it look now?
There was a problem hiding this comment.
I will have a look tomorrow again regarding the cmake changes. Maybe we can enable MacOs as well
There was a problem hiding this comment.
Is there a build for Apple silicon? I didn't see anything commented out.. and the Intel Mac build seems to at least finish. Not sure what help I can be there.
…atic and shared libraries are built. Remove outdated import library handling for libssh2.
…for better type safety and update related usages in RepoView.
…ttyup into build_fixes_for_win_mac
BrendenWalker
force-pushed
the
build_fixes_for_win_mac
branch
from
3ed7b29 to
b1b5e5f
Compare
| add_compile_options(-Werror=switch) | ||
| if(NOT MSVC) | ||
| add_compile_options(-Werror=switch) | ||
| endif() | ||
| # Uncomment to compile with more warnings add_compile_options(-Wall) Uncomment | ||
| # to compile with even more warnings add_compile_options(-Wextra) TODO: | ||
| # currently there are too many unused parameters which overwhelms the warning | ||
| # output with `-Wall`. So let's leave fixing these for later. | ||
| add_compile_options(-Wno-unused-parameter) | ||
| if(NOT MSVC) | ||
| add_compile_options(-Wno-unused-parameter) | ||
| endif() |
There was a problem hiding this comment.
Can you fix those instead of disabling it? Rest looks fine
|
Maybe the following comment could be interesting as well? b89301d#commitcomment-181010141 |
2 participants
Summary
libssh2integration issues (libssh2vsssh2import-lib naming).libssh2.dllruntime dependency.set-outputreplacement).