Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
PR fixes DNS migration behavior by adjusting dnsdist rule creation/removal and improving BIND zone/config parsing during migration.
Changes:
- Switch dnsdist master-zone redirect rule to
QNameSuffixRule(instead of separate exact + wildcard rules). - Update dnsdist rule removal logic to scan existing rules and remove matching entries.
- Enhance BIND migration parsing: extract forwarders for forward zones and normalize zone record names when importing rrsets.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| app/ldap_protocol/dns/clients/power_dnsdist_client.py | Updates dnsdist rule type for master-zone routing and changes removal logic. |
| app/ldap_protocol/dns/bind_to_pdns_migration_use_case.py | Improves parsing of forward zones/forwarders and normalizes record names during zone import. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Naksen
approved these changes
Mar 6, 2026
…tion more accurately
Naksen
pushed a commit
that referenced
this pull request
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Изменено правило и улучшен парсинг файла зоны при миграции