Conversation
Collaborator
|
☀️ The build tests passed at 00c7d00.
N.B. These results were obtained from a build of this Pull Request at 00c7d00 after being merged into the base branch at 29df87a. For more information, please check the job page here. |
|
Thank you Yuri, I think this simplified version covers everything I wanted to add in PR #521 |
|
This looks good, thank you. There is similar work in #494 that allows for selecting which VD to filter the StepPointMCs out of, but that will still require some time (for me to finish understanding the data, after which will do the review and the associated changes). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.