Open
Conversation
jwillp
requested changes
Mar 6, 2020
| */ | ||
| public function validate($v): bool | ||
| { | ||
| return strlen($v) == $this->length; |
Contributor
There was a problem hiding this comment.
In PHP, it is a best practice to test with a strict comparison: !== and ===
| */ | ||
| public function getMessage($v): string | ||
| { | ||
| return $this->message?:"'${$v}' is supposed to be exactly ".$this->length." characters long"; |
Contributor
There was a problem hiding this comment.
Can you change supposed to 'expected'?
jwillp
requested changes
Mar 8, 2020
| ) | ||
| { | ||
| if($length <0) | ||
| throw new InvalidArgumentException(); |
Contributor
There was a problem hiding this comment.
When throwing an exception, a message should always be provided in order to inform the user why the exception was thrown without needing to look at the source code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.