Warband/phase1 scene#6
Merged
MoltenCrystal merged 4 commits intoMoltenCrystal:SlopCorefrom Mar 21, 2026
Merged
Conversation
Add the group management layer for warband scenes - the system that assigns characters to groups with scene placements and sends that data to the client so it renders the warband scene on the character select screen. - Add WarbandScenePlacement DB2 store with scene-indexed lookup - Add character_warband_groups and character_warband_group_members tables - Extend EnumCharactersQueryHolder to load warband groups alongside character enumeration data - Populate WarbandGroups in the SMSG_ENUM_CHARACTERS_RESULT packet - Auto-create a default warband group when none exists - Implement CMSG_SETUP_WARBAND_GROUPS handler with full validation (scene IDs, character ownership, group limits) - Clean up warband group members on character deletion - Fix WarbandGroup::Name ownership (string_view -> string) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…nment Add complete DB2 support for all warband scene tables: - WarbandSceneAnimation, WarbandSceneAnimChrSpec, WarbandScenePlacementFilterReq - WarbandScenePlacementOption, WarbandScenePlcmntAnimOverride - WarbandPlacementDisplayInfo, WarbandSceneSourceInfo Fix WarbandScenePlacement for 12.0.1 (added Field_12_0_0_63534_008). Fix WarbandScenePlacementFilterReq layout to match client metadata. Fix all parent index fields to be unsigned as required by DB2 loader. Update warband group limit from 5 to 20 (retail 11.1+). Use DROP+CREATE for SQL tables to ensure clean schema updates. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
CHAR_SEL_WARBAND_GROUPS and CHAR_SEL_WARBAND_GROUP_MEMBERS are used in EnumCharactersQueryHolder which runs on async connections. Change from CONNECTION_SYNCH to CONNECTION_ASYNC to match. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Document stacked branch workflow for submitting each phase as a separate PR when the full warband featureset is complete. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed:
Issues addressed:
Closes # (insert issue tracker number)
Tests performed:
(Does it build, tested in-game, etc.)
Known issues and TODO list: (add/remove lines as needed)