Open
Conversation
|
Board and firmware folder for this pull request: |
|
Board and firmware folder for this pull request: |
There was a problem hiding this comment.
Pull request overview
Enables the internal pull-up resistor on the InputShifter data-in pin to prevent floating inputs when an InputShifter is configured but not physically connected (addresses issue #372).
Changes:
- Configure
_dataPinasINPUT_PULLUPinMFInputShifter::attach()to stabilize reads when the line is otherwise floating.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Enable PullUp for Data In pin for InputShifter.
Not connected InputShifter but defined on the board leads to multiple messages to the connector due to floating pin if PullUp is not enabled. This is fixed with this PR.
Fixes #372