Fix bottom sheet peek height to use resolveBottomSheetPeekHeight consistently#6216
Draft
Claude wants to merge 2 commits intofix/bottomsheet-edge-to-edgefrom
Draft
Fix bottom sheet peek height to use resolveBottomSheetPeekHeight consistently#6216Claude wants to merge 2 commits intofix/bottomsheet-edge-to-edgefrom
Claude wants to merge 2 commits intofix/bottomsheet-edge-to-edgefrom
Conversation
…istently - Remove manual navigationBarHeight addition from bottom margins (safe area now handled by resolveBottomSheetPeekHeight) - Update UserBottomSheetDialogFragment and GroupBottomSheetDialogFragment to use resolveBottomSheetPeekHeight when setting peek height - Ensure consistent safe-area inset handling between initial and dynamic peek height updates Co-authored-by: crossle <1675131+crossle@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses automated review feedback on bottom sheet safe-area handling. The peek height calculations were bypassing the base class's
resolveBottomSheetPeekHeight()helper, causing inconsistent bottom inset handling between initial and dynamic updates.Changes
resolveBottomSheetPeekHeight()already handles safe-area insets, so manual addition caused double-countingBefore:
After:
Applies to both
UserBottomSheetDialogFragmentandGroupBottomSheetDialogFragment.