refactor(ui): migrate away from deprecated SYSTEM_UI_FLAG_LAYOUT_FULL…#6184
refactor(ui): migrate away from deprecated SYSTEM_UI_FLAG_LAYOUT_FULL…#6184SeniorZhai wants to merge 2 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Refactors several UI screens to migrate away from deprecated View.SYSTEM_UI_FLAG_* fullscreen/layout flags and toward WindowInsets/WindowCompat-based edge-to-edge and system bar control.
Changes:
- Replace manual
systemUiVisibilityflag manipulation withSystemUIManager.hideSystemUI/showSystemUIinWebFragmentcustom view flow. - Switch share/blur activities to
WindowCompat.setDecorFitsSystemWindows(window, false)for edge-to-edge layout. - Update
TextPreviewActivityto hide system UI usingWindowInsetsControllerCompatinstead of deprecated flags.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| app/src/main/java/one/mixin/android/ui/web/WebFragment.kt | Uses SystemUIManager to hide/show system bars for fullscreen custom web content. |
| app/src/main/java/one/mixin/android/ui/wallet/MarketShareActivity.kt | Migrates edge-to-edge setup to WindowCompat.setDecorFitsSystemWindows(false) and keeps transparent safe padding. |
| app/src/main/java/one/mixin/android/ui/wallet/DepositShareActivity.kt | Migrates edge-to-edge setup to WindowCompat.setDecorFitsSystemWindows(false) but may miss transparent insets handling for blur UI. |
| app/src/main/java/one/mixin/android/ui/preview/TextPreviewActivity.kt | Replaces deprecated fullscreen flags with WindowInsets-based status bar hiding. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| WindowCompat.setDecorFitsSystemWindows(window, false) | ||
|
|
There was a problem hiding this comment.
DepositShareActivity now opts into edge-to-edge via setDecorFitsSystemWindows(false), but it no longer overrides BaseActivity’s default SystemUIManager.setSafePadding(... bg_white). This likely reintroduces an opaque (theme) background strip behind the status/navigation bars on this blur/overlay screen. Consider calling SystemUIManager.setSafePadding(window, Color.TRANSPARENT) (as MarketShareActivity/AvatarActivity do) or otherwise ensuring the insets area stays transparent to preserve the blurred background.
…SCREEN APIs