Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #360 +/- ##
===========================================
- Coverage 91.27% 91.26% -0.02%
===========================================
Files 120 120
Lines 6602 6592 -10
Branches 799 799
===========================================
- Hits 6026 6016 -10
Misses 381 381
Partials 195 195
🚀 New features to boost your workflow:
|
MatthieuCMira
previously approved these changes
Mar 12, 2026
Contributor
MatthieuCMira
left a comment
MatthieuCMira
left a comment
There was a problem hiding this comment.
Changes seems ok to me.
Just wondering the disparition of the "lower bound" in the uijson as it's not removed anywhere in the code
| "property": "", | ||
| "value": 0.0 | ||
| }, | ||
| "lower_bound": { |
Contributor
There was a problem hiding this comment.
I saw no removal or "user bound" in the code.
Can you confirm you want to remove it?
Collaborator
Author
There was a problem hiding this comment.
Yes, was just getting warnings in the tests. The uijson on disk was behind the code, so that cleans it up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.