security: remove hardcoded API keys and environment setup#1
Open
security: remove hardcoded API keys and environment setup#1
Conversation
BREAKING CHANGE: Git history rewritten to remove exposed credentials. All collaborators must re-clone and set FIREWORKS_API_KEY environment variable.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes all hardcoded Fireworks AI API keys from codebase and implements secure environment variable-based configuration. Adds comprehensive security documentation and enhanced git ignore patterns to prevent future credential leaks.
Changes
FIREWORKS_API_KEYenvironment variable in Python and shell scripts.gitignorewith comprehensive credential file patterns (*.env, *.key, *.pem, secrets/, etc.)SECURITY_MIGRATION.mdwith complete remediation guide covering key revocation, generation, git history scrubbing, and team coordinationSECURITY_REMEDIATION_SUMMARY.mdwith actionable checklist and verification stepsTesting
FIREWORKS_API_KEYis not setgrep -r "fw_[a-zA-Z0-9]" . --exclude-dir=.git.gitignorepatterns cover credential filesNotes
Phase 1 (IMMEDIATE):
fw_3ZNkrZnbfKVHhU65bFirkpJrfw_3ZHFp8ZR5WeoadXcFcjEKY4zPhase 2 (TODAY):
git-filter-repoor BFG (seeSECURITY_MIGRATION.md)git push origin --force --allPhase 3 (THIS WEEK):
See
SECURITY_MIGRATION.mdandSECURITY_REMEDIATION_SUMMARY.mdfor detailed instructions and checklists.Related: Security remediation for exposed API credentials