Add attribution metadat policy for BIG_DATA#610
Add attribution metadat policy for BIG_DATA#610Yaswant Pradhan (yaswant) wants to merge 3 commits intoMetOffice:mainfrom
Conversation
|
This is a good start, but there are no rules for developers. Without clear guidance on what sort of data can be added and what the supporting evidence is required, this will result in more problems during review. The PR also seems to be doing two things: adding information about the big data policy, and fixing typos and changing build instructions in other sections. These are separate and the second part needs to be split out into another PR. |
|
Good points, Sam Clarke-Green (@t00sa) - I initially thought this would be best placed in the Developer section, but since the reference to BIG_DATA was only in the Reviewer section, that's where it ended up. You're correct that some adjustments are needed. Regarding what's permitted, ANCILDIR-Deploy should be considered the single source of truth. I'll revert the typo and jules-doc compilation updates and address them in another PR. |
source/Reviewers/howtocommit.rst
Outdated
|
|
||
| Please refer to the | ||
| `Prerequisites section of the ANCILDIR-Deploy document | ||
| <https://github.com/MetOffice/ANCILDIR-Deploy?tab=readme-ov-file#prerequisites>`__. |
There was a problem hiding this comment.
Ah, one issue might be that collaborators can't see this one - it's deliberately not collaborator visible. Andy is happy that you extract / quote it here if you want.
|
Thanks both. Moved the guidance to development checklist section. Included process (extract from ANCILDIR-Deploy) here for wider visibility. |
PR Summary
IAO Approver: Ben Fitzpatrick (@benfitzpatrick)
Code Reviewer: Sam Clarke-Green (@t00sa)
Cc: Andrew Clark (@arjclark)
Adding attribution metadata policy to working practices.
Code Quality Checklist
IAO Comments
Code Review