Skip to content

add build and test ci#5

Merged
Yaswant Pradhan (yaswant) merged 90 commits intoMetOffice:mainfrom
james-bruten-mo:build_and_test
Oct 2, 2025
Merged

add build and test ci#5
Yaswant Pradhan (yaswant) merged 90 commits intoMetOffice:mainfrom
james-bruten-mo:build_and_test

Conversation

@james-bruten-mo
Copy link
Copy Markdown
Collaborator

PR Summary

Code Reviewer:

Add a build and unittest of some mule modules.
This only works for the mule and um_utils modules as all others require external input - the dependency on shumlib feels like something we can get working, but I think we should do that later.

Code Quality Checklist

(Some checks are automatically carried out via the CI pipeline)

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid undertanding and enhance the
    readability of the code
  • My changes generate no new warnings

Testing

  • I have tested this change locally, using the rose-stem suite
  • If any tests fail (rose-stem or CI) the reason is understood and
    acceptable (eg. kgo changes)
  • I have added tests to cover new functionality as appropriate (eg. system
    tests, unit tests, etc.)

trac.log

Security Considerations

  • This change does not introduce security vulnerabilities
  • I have reviewed the code for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable
    performance measurements have been conducted

Contributor License Agreement (CLA)

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance
    of Generative AI tool name (e.g., Met Office Github Copilot Enterprise,
    Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the
    Simulation Systems AI policy (including
    attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and
    confirmed that it builds correctly

Code Review

  • All dependencies have been resolved
  • Related Issues are properly linked and addressed
  • CLA compliance is confirmed
  • Code quality standards are met
  • Tests are adequate and passing
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

@james-bruten-mo
Copy link
Copy Markdown
Collaborator Author

James Bruten (james-bruten-mo) commented Oct 2, 2025

Yaswant Pradhan (@yaswant) After only a few iterations I've got this building the standalone mule libraries and unit testing. This is hardcoded to python3.13 and numpy 2.2.6 at the moment. It'd be good to run with those settings, and also do a test with numpy 1.26.4. Is there a better way to do this than what I've got right now?

I guess ideally it wouldn't use a requirements.txt file as they're not actually requirements

@james-bruten-mo
Copy link
Copy Markdown
Collaborator Author

Yaswant Pradhan (@yaswant) have answered my own question by using a matrix. If you have a chance to review that would be great

@james-bruten-mo James Bruten (james-bruten-mo) added the crSet This is added to a pull request once the SSD team have assigned a code reviewer. label Oct 2, 2025
@yaswant
Copy link
Copy Markdown
Collaborator

We can include shumlib in the build (once public that will be easy, otherwise we will need to add secrets), but you mentioned that there is um dependency too - can you point me to the code where it needs UM?

Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
@yaswant Yaswant Pradhan (yaswant) merged commit 5131ebc into MetOffice:main Oct 2, 2025
7 checks passed
@james-bruten-mo James Bruten (james-bruten-mo) deleted the build_and_test branch October 3, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

crSet This is added to a pull request once the SSD team have assigned a code reviewer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants