Skip to content

Small changes to support ML FastNet and Pangu#2006

Open
James W (jwarner8) wants to merge 6 commits intomainfrom
fix_ml
Open

Small changes to support ML FastNet and Pangu#2006
James W (jwarner8) wants to merge 6 commits intomainfrom
fix_ml

Conversation

@jwarner8
Copy link
Copy Markdown
Contributor

Fixes issues with cube concatenation with extra attributes, and ensures forecast_period units are standardised.

Contribution checklist

Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

  • Documentation has been updated to reflect change.
  • New code has tests, and affected old tests have been updated.
  • All tests and CI checks pass.
  • Ensured the pull request title is descriptive.
  • Ensure rose-suite.conf.example has been updated if new diagnostic added.
  • Conda lock files have been updated if dependencies have changed.
  • Attributed any Generative AI, such as GitHub Copilot, used in this PR.
  • Marked the PR as ready to review.

@jwarner8 James W (jwarner8) self-assigned this Mar 31, 2026
@jwarner8 James W (jwarner8) added the small Small issue that should be quick to resolve label Mar 31, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 31, 2026

Coverage

Copy link
Copy Markdown
Member

@jfrost-mo James Frost (jfrost-mo) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like sensible changes, though we want a test to make sure the convert units is happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

small Small issue that should be quick to resolve

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants