Updates recipes to add in extra constraining for speed#1986
Conversation
|
This is ready to review, but am keeping it as draft to ensure it is not merged prior to further discussion with James Frost (@jfrost-mo). It maybe that some of the PRs (e.g. #1905) in development may supersede this PR, and so we will not need to merge it. |
|
Note: if the route applied here is the decided route we will need to update all other recipes where we derive diagnostics to be similar. |
|
See #1999 for deployment of this approach successfully. Note needed to also run with a cell_methods constraint here to avoid loading in multiple time-processed instances of same variable. Not 100% clear on equivalence to ['VARNAME', land_binary_mask] here (i.e. does applying empty cell_methods to land_binary_mask work ok? Was the original land_sea_mask recipes tested on inputs with potential for multiple instances of same varname? |
James Frost (jfrost-mo)
left a comment
There was a problem hiding this comment.
This extra constraining seems like a sensible approach to reduce the number of cubes loaded. My only concern is whether the name "land_binary_mask" is sufficiently generic to be used across different models, but given it was already hard-coded it should be fine.
When I get #1905 to completion it will remove most of the benefit of this change, but it still won't hurt, so I see no reason not to do it.
Updates the recipes as suggested by Scott Wales (@ScottWales) in a generic form to help speed up the land sea mask recipes.
Fixes #1981
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.
rose-suite.conf.examplehas been updated if new diagnostic added.