Skip to content

Convert forecast period units to fix no overlap, and remove additional attributes#1974

Closed
James Warner (jwarner8) wants to merge 2 commits intomainfrom
multimodel_ml_comp
Closed

Convert forecast period units to fix no overlap, and remove additional attributes#1974
James Warner (jwarner8) wants to merge 2 commits intomainfrom
multimodel_ml_comp

Conversation

@jwarner8
Copy link
Copy Markdown
Contributor

As per title, FastNet not working as it reports forecast_period in seconds, and overlap literally evaluates forecast_period numbers. This fix ensures that they use a common time unit.

Also adds some additional attributes to pop that prevent cube merging.

Contribution checklist

Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

  • Documentation has been updated to reflect change.
  • New code has tests, and affected old tests have been updated.
  • All tests and CI checks pass.
  • Ensured the pull request title is descriptive.
  • Ensure rose-suite.conf.example has been updated if new diagnostic added.
  • Conda lock files have been updated if dependencies have changed.
  • Attributed any Generative AI, such as GitHub Copilot, used in this PR.
  • Marked the PR as ready to review.

@github-actions
Copy link
Copy Markdown
Contributor

Coverage

@jwarner8
Copy link
Copy Markdown
Contributor Author

Closing as these changes are already on trunk from a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant