Open
Conversation
5 tasks
gabriel-bolbotina
force-pushed
the
fix/android-photo-orientation
branch
from
d3a92ea to
dfc7b71
Compare
📦 Build Artifacts Ready
|
Withalion
approved these changes
Mar 9, 2026
📦 Build Artifacts Ready
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ready for review
Solution: instead of erasing the exif data key for image orientation, it is not set to 1 (which means no rotation). I also modified the unit test to check that the value of that key is set to 1, when calling the modified function.
Tested on iOS, Android and Windows