[CS-148] Set s3 client config setting to validate checksum only when required#35638
Open
patrickwwbutler wants to merge 6 commits intoMaterializeInc:mainfrom
Open
[CS-148] Set s3 client config setting to validate checksum only when required#35638patrickwwbutler wants to merge 6 commits intoMaterializeInc:mainfrom
patrickwwbutler wants to merge 6 commits intoMaterializeInc:mainfrom
Conversation
Contributor
|
Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone. PR title guidelines
Pre-merge checklist
|
martykulma
reviewed
Mar 26, 2026
martykulma
approved these changes
Mar 31, 2026
Contributor
martykulma
left a comment
There was a problem hiding this comment.
Thanks @patrickwwbutler, looks great! I happened to look up path-style access and found AWS is in the process of deprecating it, so we probably need to avoid it in case it causes problems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using COPY FROM on parquet files from GCS, we make requests for ranges of the files, but GCS does not support checksums for partial objects, causing us to get checksum errors. This setting avoids these validations and makes
copy from gcspossible with parquet files.