This repository was archived by the owner on Nov 5, 2019. It is now read-only.
Make visualization of gates configurable#3
Open
TheComputerGeek2 wants to merge 1 commit intoMassiveCraft:masterfrom
Open
Make visualization of gates configurable#3TheComputerGeek2 wants to merge 1 commit intoMassiveCraft:masterfrom
TheComputerGeek2 wants to merge 1 commit intoMassiveCraft:masterfrom
Conversation
magnusulf
reviewed
May 8, 2018
| public Material visFrame = Material.JACK_O_LANTERN; | ||
| public Material visContent = Material.GLOWSTONE; | ||
| public Material visPower = Material.STATIONARY_LAVA; | ||
|
|
Contributor
There was a problem hiding this comment.
May I suggest more expressive names such as "visualizationBlockFrame", "visualizationBlockContent", "visualizationBlockPower"?
Member
Author
There was a problem hiding this comment.
Sounds good to me
| { | ||
| Set<Block> frame = FloodUtil.getFrameFor(content, orientation); | ||
| gate.addFrameBlocks(frame); | ||
| VisualizeUtil.addBlocks(me, frame, Const.visFrame); |
Contributor
There was a problem hiding this comment.
You ought to be able to delete these variables from Const.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.