Skip to content

Rules.py misc changes#201

Open
nicopop wants to merge 13 commits intomainfrom
rules.py-misc-changes
Open

Rules.py misc changes#201
nicopop wants to merge 13 commits intomainfrom
rules.py-misc-changes

Conversation

@nicopop
Copy link
Copy Markdown
Contributor

@nicopop nicopop commented Feb 2, 2026

I got inspired by what I said on discord in manual-core-dev channel and I went and really looked at the rules.py file
things included in this PR so far:

  • Replaced the old state.counts call loops with calls to either state.has or state.has_from_list
    • fixes events not being accessible via @category, :half/:all
  • Added Some type anotations to make mypy happy
  • Made item_count convert back to item_name if the count is an unknown string

that last point can be reverted/modified if we still want it to raise an exception instead

@nicopop nicopop self-assigned this Feb 2, 2026
silasary
silasary previously approved these changes Feb 5, 2026
@nicopop
Copy link
Copy Markdown
Contributor Author

nicopop commented Feb 14, 2026

Actuallly im putting this PR on pause until the rule builder one is merged (link here once its created)

@nicopop nicopop added the blocked by feedback This PR is blocked by feedback in the PR label Feb 14, 2026
@silasary
Copy link
Copy Markdown
Contributor

#203 is the rule builder PR

@nicopop nicopop mentioned this pull request Feb 14, 2026
@nicopop
Copy link
Copy Markdown
Contributor Author

nicopop commented Mar 30, 2026

with pr #203 merged ill adapt this PR to the new code,
I don't have time this week but I should work on this soonish™

@nicopop
Copy link
Copy Markdown
Contributor Author

nicopop commented Mar 31, 2026

with pr #203 merged ill adapt this PR to the new code, I don't have time this week but I should work on this soonish™

I didnt mean to lie when I said that, I just got inspired when doing the preparatory merge from main to fix the conflicts

@nicopop nicopop removed the blocked by feedback This PR is blocked by feedback in the PR label Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants