Conversation
- Remove unused MaxRemoveIterations constant from CodePostProcessor - Add defensive check for single-character parts in PascalCasePropertyNameGenerator - Improve JetBrainsCleanupRunner to dynamically find solution directory - Add explicit Microsoft.Extensions.Logging.Abstractions package reference to test project - Change HashSet<string> to IReadOnlySet<string> in SchemaAnalysisResult for immutability - Improve error messages with actual schema counts for better debugging - Add ConfigureAwait(false) to all async calls in library code
- Update TargetFramework from net8.0 to net10.0 - Update CI and Release workflows to use dotnet-version 10.0.x - Aligns with existing .NET 10 package dependencies
- Push nupkg to Magnet/Engineering feed during GitHub Release - Requires AZURE_ARTIFACTS_PAT secret to be configured
- Fix Azure Artifacts auth: use PAT directly instead of env var - Add trailing newline to DotSchema.Tests.csproj - Fix single-char edge case in SchemaAnalyzer.ExtractInlineTypeHashes
lonecat13
added a commit
that referenced
this pull request
Mar 24, 2026
Code review fixes and .NET 10 upgrade
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses all issues identified in the code review and upgrades the project to .NET 10.
Code Review Fixes
MaxRemoveIterationsfromCodePostProcessor.csPascalCasePropertyNameGeneratorJetBrainsCleanupRunnerto walk up directories to find.slnfile instead of hardcoded 3-level traversalMicrosoft.Extensions.Logging.Abstractionsto test projectHashSet<string>toIReadOnlySet<string>inSchemaAnalysisResultfor better API design.NET 10 Upgrade
TargetFrameworkfromnet8.0tonet10.0dotnet-version: 10.0.xTesting