Add needed overrides to ReliableSqlClientBatchingBatcher for (at least some of) the new async methods added to SqlClientBatchingBatcher#38
Open
gmcelhanon wants to merge 2 commits intoMRCollective:masterfrom
Conversation
… for new async methods added by NHibernate in the ReliableSqlClientBatchingBatcher. (NOTE: Did not perform a full analysis for other missing overrides -- added just the ones our project needed).
1 similar comment
…tch NHibernate5.SqlAzure project upgrade on previous commit.
1 similar comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated project to NHibernate v5.3.9 and added some missing async overrides in
ReliableSqlClientBatchingBatcherfor new async methods added by NHibernate inSqlClientBatchingBatcher.(NOTE: Did not perform a full analysis for other possibly missing overrides -- just added and verified expected behavior for the ones needed for our project).