Conversation
|
Hi Diego, Thanks for the pull request! Really awesome to see this library being actively used, and Oracle driver support would definitely be of huge benefit to some people. Before I merge this in, I just wanted to confirm you definitely need this driver to use System.Data.OracleClient. That's been deprecated for a while in favour of Oracle.DataAccess and the newer (and much nicer) Oracle.ManagedDataAccess. I think it would make sense to rename MiniProfilerOracle10ClientDriver -> MiniProfilerOracleClientDriver and add an xmldoc comment explaining that you need System.Data.OracleClient 2.0.0.0 referenced to use it. We can additionally add in support for OracleDataClientDriver and OracleManagedDataClientDriver at a later date. One other issue as well that I've added a line comment for. If you're happy with all the above I'll make those tweaks and push out a package tonight. Thanks again! Cheers |
|
The SQL 2008 client driver seems to have all its line endings changed; you probably should make sure the commits use consistent line endings (crlf for everything - you might need to turn off the autocrlf setting on your git to achieve that). We should probably put in a gitattributes file to prevent that happening in the future as well. |
Added Oracle Driver