Merged
Conversation
Modifies tempPrefix to first use the $TMPDIR environment variable. It only uses the $TMPDIR location if the path is absolute, canonical, and already exists as a directory. Closes MLton#642.
Member
|
Looks fine to me. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifies tempPrefix to first try to use the $TMPDIR environment variable. It only uses the $TMPDIR location if the path is absolute, canonical, and already exists as a directory.
This set of checks is based on the code in systemd here.
Considerations
Languages such as Python also check
TEMP,TMP, and more locations: docs. It also performs the existence checks to the hardcoded locations, so if/tmpdoesn't exist it can fallback to/var/tmp. I don't think this is a big deal: if a program wants to they can use themkstempsfunction themselves.Python caches the temporary directory check, so it doesn't call
isDirevery time. I don't think this is a meaningful cost since there's only one directory to check.Rust uses
confstr(_CS_DARWIN_USER_TEMP_DIR)to determine the temporary directory on Darwin: link. This isn't implemented here.Feel free to modify the code if those mentioned options are appealing.
Closes #642.