Open
Conversation
daniwhite
requested changes
Oct 5, 2018
src/bms/src/canmgr.c
Outdated
| msg.hash3 = HASH[3]; | ||
| msg.hash4 = HASH[4]; | ||
| msg.hash5 = HASH[5]; | ||
| msg.board = 0; |
Collaborator
There was a problem hiding this comment.
If you look at the enum_segments.h file in the can library it shows what enums are generated. You should use the names from that enum (for example,msg.board = can0_GitHash_board_BMS).
| is_big_endian: true | ||
| period: 1000 ms | ||
| segments: | ||
| hash0: |
Collaborator
There was a problem hiding this comment.
Might be nice to add a comment explaining exactly what hash0, hash1, etc. are for.
| cs->soc = msg.soc; | ||
| } | ||
|
|
||
| void can_handle_mc_temperature1(carstats_t *cs) { |
Collaborator
There was a problem hiding this comment.
Did you commit this separately into roman? I'm suspicious this is what's causing your conflict.
src/frontCANnode/src/output.c
Outdated
|
|
||
| void write_can_left_wheel_speed_msg() { | ||
| LIMIT(can0_FrontCanNodeLeftWheelSpeed_period) | ||
| LIMIT(can0_FrontCanNodeLeftWheelSpeed_period); |
Collaborator
There was a problem hiding this comment.
What is this change in here for? It seems unrelated.
Collaborator
Author
|
Made suggested changes. But for some reason there's this plotting stuff? |
Collaborator
daniwhite
approved these changes
Oct 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the new member project to allow all the boards to send out part of their git hash over CAN once a second. There are also some fixes of typos that were causing compile errors.