Skip to content

Allow to disable the automatic rdb snapshot in valkey#403

Open
claudex wants to merge 1 commit intoMISP:masterfrom
claudex:feat/disable-cache-snapshot
Open

Allow to disable the automatic rdb snapshot in valkey#403
claudex wants to merge 1 commit intoMISP:masterfrom
claudex:feat/disable-cache-snapshot

Conversation

@claudex
Copy link
Contributor

@claudex claudex commented Mar 26, 2026

By default, Valkey dumps regularly a snapshot, on testing/demo environnment, we may want to avoid the extra fs pressure

By default, Valkey dumps regularly a snapshot, on testing/demo
environnment, we may want to avoid the extra fs pressure
Copy link
Collaborator

@ostefano ostefano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be "DISABLE" since this is soemthing that should always be enabled bar additional cases?

@claudex
Copy link
Contributor Author

claudex commented Mar 26, 2026

Yes, but I find less confusing to read something ENABLE=true than DISABLE=false because it avoids double negation. But I can change it if you prefer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants