Bug-Fix when setting TZ with delimitter /#394
Merged
ostefano merged 17 commits intoMISP:masterfrom Mar 17, 2026
Merged
Conversation
Add timezone setting option to template.env
- Add timezone environment variable to all services - Setting Default to "UTC"
- Add timezone configuration for PHP in docker-compose file. - Replace PHP timezone in misp-core with the new config-file tzone.ini Perhaps there are better solutions for changing the time zone from PHP during runtime.
Updated PHP timezone configuration and added symlink for timezone for supervisord.
sed dosen´t use "?" so PHP_TIMEZONE was setting in php.ini
PHP_TIMEZONE wasn`t in template.env and so most not in use. TZ Variable the global Timezone variable in this Project
Removed timezone configuration from docker-compose. With the "sed fix" in the entrypoint_fpm.sh, No need to mount a separate file now
Updated timezone setting method for supervisord compatibility with debian standard methode
add `-` so default (UTC) is in use, if TZ is not in use
PHP_timezone isn`t in use TZ exist
CET or CEST not useable timezone in /usr/share/zoneinfo/
Remove default value for TZ when setting timezone.
switch delimitter `/` to `|`
LSI-ZuagrastaWastl
referenced
this pull request
Mar 16, 2026
* Add timezone setting to template.env Add timezone setting option to template.env * Add timezone environment variable to services - Add timezone environment variable to all services - Setting Default to "UTC" * Add PHP timezone config to docker-compose - Add timezone configuration for PHP in docker-compose file. - Replace PHP timezone in misp-core with the new config-file tzone.ini Perhaps there are better solutions for changing the time zone from PHP during runtime. * Change PHP timezone variable and set localtime Updated PHP timezone configuration and added symlink for timezone for supervisord. * Fix timezone setting in PHP configuration sed dosen´t use "?" so PHP_TIMEZONE was setting in php.ini * Change PHP_TIMEZONE variable to use TZ PHP_TIMEZONE wasn`t in template.env and so most not in use. TZ Variable the global Timezone variable in this Project * Remove tzone.ini configuration from docker-compose Removed timezone configuration from docker-compose. With the "sed fix" in the entrypoint_fpm.sh, No need to mount a separate file now * Change timezone setting to use update-alternatives Updated timezone setting method for supervisord compatibility with debian standard methode * sed TZ:UTC to TZ:-UTC add `-` so default (UTC) is in use, if TZ is not in use * Change php-timezone variable to use TZ directly * Remove PHP_TIMEZONE environment variable PHP_timezone isn`t in use TZ exist * Update PHP timezone configuration to TZ in entrypoint_fpm.sh * Update timezone comment in template.env CET or CEST not useable timezone in /usr/share/zoneinfo/ * Update timezone setting in entrypoint.sh Remove default value for TZ when setting timezone.
Collaborator
|
Thank you ❤️ |
1 similar comment
Collaborator
|
Thank you ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
A bug was identified when setting the
date.timezoneconfiguration in the PHP file due to the delimiter used insed.This fix changes the delimiter from/to|to avoid conflicts with the slash in thedate.timezonevalue.Change:
The sed command has been updated to use an alternate delimiter (|).
This bug fix resolves #393