Update google benchmark to version v1.9.5

[PardhavMaradani]

This PR updates google benchmark version to v1.9.5 due to issues described in this comment and this comment. Thanks

[orbeckst]

After git submodule update --remote I get

git submodule status
+fc8a082c6046691091eecea36b2972a50c96c8f2 googlebench (v1.9.4-141-gfc8a082)
+d72f9c8aea6817cdf1ca0ac10887f328de7f3da2 googletest (release-1.8.0-3627-gd72f9c8a)
-ac0d5d297b13ab1b89f48484fc7911082d76a93f highway

Is this what you have?

[PardhavMaradani]

It shows the following for me:

git submodule status
 192ef10025eb2c4cdd392bc502f0c852196baa48 libdistopia/googlebench (v1.9.4-102-g192ef10)
 2dd1c131950043a8ad5ab0d2dda0e0970596586a libdistopia/googletest (release-1.8.0-3387-g2dd1c131)
 ac0d5d297b13ab1b89f48484fc7911082d76a93f libdistopia/highway (1.3.0)

The 192ef100 matches the diff from this PR. Not sure why it is different in your case. 192ef100 is also the commit for google benchmark v1.9.5 tag Thanks

[orbeckst]

Getting your branch (git pull git@github.com:PardhavMaradani/distopia.git google-benchchmark-v195) and not doing anything else:

$ git submodule status
+ca8d0f7b613ac915cd6b161ab01b7be449d1e1cd libdistopia/googlebench (v1.8.3-3-gca8d0f7)
 2dd1c131950043a8ad5ab0d2dda0e0970596586a libdistopia/googletest (release-1.8.0-3387-g2dd1c131)
 ac0d5d297b13ab1b89f48484fc7911082d76a93f libdistopia/highway (1.3.0)

Then

$ git submodule update --remote
Submodule path 'libdistopia/googlebench': checked out 'fc8a082c6046691091eecea36b2972a50c96c8f2'
Submodule path 'libdistopia/googletest': checked out 'd72f9c8aea6817cdf1ca0ac10887f328de7f3da2'
Submodule path 'libdistopia/highway': checked out 'a43090982bc0941b264725daa539a93c6e04c0e6'

$ git submodule status
+fc8a082c6046691091eecea36b2972a50c96c8f2 libdistopia/googlebench (v1.9.4-141-gfc8a082)
+d72f9c8aea6817cdf1ca0ac10887f328de7f3da2 libdistopia/googletest (release-1.8.0-3627-gd72f9c8a)
+a43090982bc0941b264725daa539a93c6e04c0e6 libdistopia/highway (1.3.0-331-ga4309098)

Either way, I can confirm that it's working

• pytest pass
• ctest pass
• benchmark runs

[PardhavMaradani]

fc8a08 points to the latest commit in their repo. This PR points to their v1.9.5 tag.

[orbeckst]

How do you make submodules update to the v1.9.5 tag?

EDIT: Basically, how should I be using submodule here? There's no doc (see #191 ...) and init/update was the best I could figure out.

[PardhavMaradani]

I did a git checkout 192ef10 in the submodule to get the v1.9.5 tag - I thought this would be better than some arbitrary commit on main for the future. Thanks

update: I added a review comment in the PR. Thanks

update: After pulling changes, I think just git submodule update --recursive would do. You seem to be updating from the remote, which is why it is getting their latest commit. Without the remote, you should just get what is in this repo.

[orbeckst]

I still don't understand how I will get your version of the submodules but CI is happy and only the benchmark code was changed, so I am fairly confident that nothing will break.

[PardhavMaradani]

I still don't understand how I will get your version of the submodules but CI is happy and only the benchmark code was changed, so I am fairly confident that nothing will break.

I just updated the previous comment. Thanks

[orbeckst]

Yes, git submodule update did the trick. Thanks. I want to say that I tried it before but as it didn't seem to do anything I tried --remote. On main I am now getting what you listed:

(distopia) r2p2:distopia oliver$ git submodule update
Submodule path 'libdistopia/googlebench': checked out '192ef10025eb2c4cdd392bc502f0c852196baa48'
Submodule path 'libdistopia/googletest': checked out '2dd1c131950043a8ad5ab0d2dda0e0970596586a'
Submodule path 'libdistopia/highway': checked out 'ac0d5d297b13ab1b89f48484fc7911082d76a93f'

(distopia) r2p2:distopia oliver$ git submodule status
 192ef10025eb2c4cdd392bc502f0c852196baa48 libdistopia/googlebench (v1.9.4-102-g192ef10)
 2dd1c131950043a8ad5ab0d2dda0e0970596586a libdistopia/googletest (release-1.8.0-3387-g2dd1c131)
 ac0d5d297b13ab1b89f48484fc7911082d76a93f libdistopia/highway (1.3.0)