Skip to content

work around clang warn/error on __COUNTER__ #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
orbeckst wants to merge 1 commit into from
Closed

work around clang warn/error on __COUNTER__ #193

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions libdistopia/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,23 @@ endif()
if(DISTOPIA_BUILD_TESTS)

set(BENCHMARK_ENABLE_TESTING OFF CACHE BOOL "Enable googlebench tests" FORCE)
# Newer Clang warns on __COUNTER__ in #if (C2y extension); googlebench uses -Werror.
set(BENCHMARK_ENABLE_WERROR OFF CACHE BOOL "Build googlebench without -Werror" FORCE)
add_subdirectory("googlebench")
# Clang 17+ warns on __COUNTER__ in #if (C2y); -pedantic-errors still makes it fatal for googlebench.
if(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
target_compile_options(benchmark PRIVATE -Wno-c2y-extensions)
target_compile_options(benchmark_main PRIVATE -Wno-c2y-extensions)
endif()

add_executable(bench)
target_sources(bench PRIVATE "test/bench.cpp")
target_link_libraries(bench PUBLIC benchmark::benchmark)
target_link_libraries(bench PUBLIC libdistopia)
target_include_directories(bench PUBLIC ${CMAKE_CURRENT_LIST_DIR})
if(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
target_compile_options(bench PRIVATE -Wno-c2y-extensions)
endif()



Expand Down
Loading