[pull] forks/amsterdam from ethereum:forks/amsterdam#159
Merged
pull[bot] merged 2 commits intoLuckQuack:forks/amsterdamfrom Apr 8, 2026
Merged
[pull] forks/amsterdam from ethereum:forks/amsterdam#159pull[bot] merged 2 commits intoLuckQuack:forks/amsterdamfrom
pull[bot] merged 2 commits intoLuckQuack:forks/amsterdamfrom
Conversation
…code_node functions (#2627) * fix: Remove inaccurate 'unimplemented stub' comment from encode_node The encode_node function in berlin/trie.py was documented as 'Currently mostly an unimplemented stub' but it is actually fully implemented, handling Account, LegacyTransaction, Receipt, U256, Uint, Bytes types, and falling back to previous_trie.encode_node. This misleading docstring could confuse developers reading the code. Fixes #1186 * fix: Remove inaccurate 'unimplemented stub' comments from all fork encode_node functions The encode_node function is fully implemented across all Ethereum fork implementations, handling Account, LegacyTransaction, Receipt, U256, Uint, Bytes types, and falling back to previous_trie.encode_node. However, 24 fork versions had docstrings claiming the function was 'Currently mostly an unimplemented stub', which is factually incorrect and could mislead developers reading the code. This commit removes the inaccurate comment from all affected forks: amsterdam, arrow_glacier, bpo1-5, byzantium, cancun, constantinople, dao_fork, frontier, gray_glacier, homestead, istanbul, london, muir_glacier, osaka, paris, prague, shanghai, spurious_dragon, tangerine_whistle Fixes #1186 * Update trie.py --------- Co-authored-by: Kubudak90 <kubudak@outlook.com> Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )