Skip to content

[pull] forks/amsterdam from ethereum:forks/amsterdam#152

Merged
pull[bot] merged 1 commit intoLuckQuack:forks/amsterdamfrom
ethereum:forks/amsterdam
Apr 1, 2026
Merged

[pull] forks/amsterdam from ethereum:forks/amsterdam#152
pull[bot] merged 1 commit intoLuckQuack:forks/amsterdamfrom
ethereum:forks/amsterdam

Conversation

@pull
Copy link
Copy Markdown

@pull pull bot commented Apr 1, 2026

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.4)

Can you help keep this open source service alive? 💖 Please sponsor : )

* refactor(ci): replace tox with Justfile using uv run

Replace tox.ini with a Justfile that uses `uv run` as the execution
layer. All 14 tox environments are now just recipes with grouped
listings, positional argument passthrough, and `.just/` as the output
directory.

- Create Justfile with grouped recipes (static analysis, fill,
  integration tests, unit tests, benchmarks, docs).
- Update setup-uv action to install just-bin instead of tox.
- Update all CI workflows to use `just <recipe>` instead of `tox -e`.
- Update composite actions (merge-eip-branches, rebase-eip-branch).
- Update PR template, tox_helpers.py, and clean.py references.
- Add .just/ to .gitignore.
- Delete tox.ini.

* chore(ci): improve Justfile recipe descriptions

Tweak descriptions carried over from tox.ini to better reflect what
each recipe actually does (e.g. "Fill" instead of "Run" for benchmark
recipes that use fill, and "EELS" instead of "specification code").

* feat(ci): add fix recipe for auto-fixing ruff format and lint issues

* refactor(ci): split static checks into individual recipes

Split the monolithic static recipe into individually-callable recipes
(spellcheck, lint, format-check, mypy, ethereum-spec-lint, lock-check,
actionlint) with static as an aggregate. Use tool-agnostic recipe names.
Also add a fix recipe for auto-fixing ruff issues.

* fix(ci): ensure .just output directories exist before recipes run

Add a private setup recipe that creates .just/tmp and .just/logs, and
wire it as a dependency for all recipes that write to those paths.
Fixes FileNotFoundError when running recipes on a fresh checkout.

* feat(ci): redirect all fill output to .just/<recipe>/ subdirectories

Write fixtures, tmp, logs, and coverage to per-recipe directories under
.just/ instead of user-visible locations like ./fixtures/. This prevents
just recipes from clobbering user-generated fixture directories.

* feat(ci): redirect mkdocs output to .just/mkdocs/site/

* chore(ci): add fix hints and whitelist recipe to static checks

Add failure hints to spellcheck and lock-check recipes showing how to
fix issues. Add whitelist recipe for adding words to the spellcheck
whitelist. Add *args to lint, format-check, and mypy for flexibility.

* docs: update CLAUDE.md and skill files for tox → just migration

* refactor(tooling): rename tox_helpers to ci_helpers, remove dead code

Remove pyspelling and codespell wrappers that are no longer called
by the Justfile. Rename the module to reflect its actual purpose.

* chore: update .tox references to .just in pyproject.toml

* docs: update README, CONTRIBUTING, and EIP_AUTHORS_MANUAL for tox → just

* docs: update docs/ pages for tox → just migration

* chore: extract latest_fork variable in Justfile

Avoid updating multiple recipes when the active fork changes by
centralizing the --until fork name in a single variable.

* chore: improve just recipes, sections and docstrings

* chore: order static recipe by fast->slow commands

* chore: add just clean and clean-all recipes

* chore: add just coverage recipe

* ci: retrigger

* docs: fix readme markdownlint

* ci: retrigger

* fix(ci): rename py3 -> fill in test.yaml, fix markdown list style

* fix(ci): ensure geth is available for `tests_pytest_py*` jobs

* fix(ci): xfail test_ci_multi_t8n_support pending geth evm build (#2557)

Mark as xfail because CI does not build the geth evm command. Under
tox this test passed trivially because the CI env var was not forwarded.

* Revert "fix(ci): ensure geth is available for `tests_pytest_py*` jobs"

This reverts commit c550027.

* chore(ci): only pin just major.minor version; not patch

* chore(tooling): rename default->list; set default & private attributes

* chore(tooling): quote `latest_fork` vars in `Justfile`

* chore(tooling): align default configured docc output dir w/just

* chore(tooling): execute static sub-recipes in parallel

* chore(tooling): add just help recipe as alias for list

* chore(ci): apt-install just instead of using taiki-e/install-action

* Revert "chore(ci): apt-install just instead of using taiki-e/install-action"

This reverts commit c8c2c09.

* docs: fix `just mypy` → `just typecheck` in docs

The recipe was renamed to `typecheck` but the documentation still
referenced the old `mypy` name.

* chore: rename GEN_TEST_DOC_VERSION sentinel from "just" to "local"

The value is only used as a truthy sentinel for local strict doc builds.
"local" better describes its purpose and avoids confusion with the just
command runner.

* chore: remove unused write_github_summary function

Dead code — defined but never called. Can be restored from git history
if needed.

* refactor(tooling): rename just recipes for CLI ergonomics

Revisit recipe names from first principles for shorter, consistent,
and more intuitive CLI usage. All hyphens, no underscores.

Renames:
- ethereum-spec-lint → spec-lint
- tests_pytest_py3 → test-tests
- tests_pytest_pypy3 → test-tests-pypy
- tests_benchmark_pytest_py3 → test-tests-bench
- pypy3 → fill-pypy
- json_loader → json-loader
- markdownlint → md-lint
- benchmark-gas-values → bench-gas
- benchmark-fixed-opcode-cli → bench-opcode
- benchmark-fixed-opcode-config → bench-opcode-config

Updates all CI workflows and documentation references.

* docs: add shell auto-completion instructions to CONTRIBUTING.md

Document how to enable tab-completion for just recipes using the
built-in `just --completions` command for bash, zsh, and fish.

* chore(tooling): add tox.ini migration stub

Provide a tox.ini that prints migration messages directing users to the
equivalent just recipes. Helps contributors still using muscle-memory
`tox -e py3` commands discover the new workflow.

* chore(ci): rename markdownlint job ID to lint-md

Align workflow job ID with the Justfile recipe rename.

* refactor(tooling): rename actionlint recipe to lint-actions

Group with other lint-* recipes for tab-completion consistency.

* chore: fix typo
@pull pull bot locked and limited conversation to collaborators Apr 1, 2026
@pull pull bot added the ⤵️ pull label Apr 1, 2026
@pull pull bot merged commit 1e49423 into LuckQuack:forks/amsterdam Apr 1, 2026
@pull pull bot had a problem deploying to github-pages April 1, 2026 20:18 Failure
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant