Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces improvements to the encrypted persistence middleware, focusing on preventing data loss and ensuring correct handling of queued writes during user session changes. The main changes include session-scoped write queues, best-effort flushes on logout, and enhanced test coverage for these behaviors.
Session management and data integrity:
encryptedMiddleware.jsto prevent replaying stale writes across user logins and logouts, and implemented logic to drop queued writes if the authentication context changes. [1] [2]flushWriteQueueForCurrentSessionandclearWriteQueuefunctions to support best-effort flushing and queue clearing during logout or session changes, and updatedsetCurrentUserForMiddlewareandclearCurrentUserFromMiddlewareto handle session transitions. [1] [2]logoutfunction inAuthContext.jsxto flush queued writes before clearing authentication state, reducing potential data loss. [1] [2]Testing improvements:
encryptedMiddleware.test.jsto verify that queued writes are not replayed after logout and subsequent login, and that writes are flushed for the active session before logout.Dependency and version update:
2.5.0-rc.0inpackage.jsonto reflect these middleware and session management enhancements.Changes
Testing
Checklist
Related Issues
Manual QA