Skip to content

Add support for wasm64 with simd128#233

Open
KonaeAkira wants to merge 8 commits intoLokathor:mainfrom
KonaeAkira:pr/wasm64
Open

Add support for wasm64 with simd128#233
KonaeAkira wants to merge 8 commits intoLokathor:mainfrom
KonaeAkira:pr/wasm64

Conversation

@KonaeAkira
Copy link
Copy Markdown
Contributor

Even though the memory64 feature has been standardized, the wasm64-unknown-unknown target is currently only a tier 3 target, so it's perfectly understandable if you don't want to merge this PR.

I stumbled upon this while experimenting with building my project with wasm64-unknown-unknown.

@KonaeAkira KonaeAkira marked this pull request as draft November 8, 2025 19:46
@Lokathor
Copy link
Copy Markdown
Owner

Lokathor commented Nov 8, 2025

I don't know that the build_check_only pass uses Nightly at all, so you'll probably have to change it to be a Nightly CI pass.

@KonaeAkira
Copy link
Copy Markdown
Contributor Author

KonaeAkira commented Nov 8, 2025

Turns out I was looking at the wrong matrix. Thanks :)

@KonaeAkira
Copy link
Copy Markdown
Contributor Author

Huh, why is the i686-pc-windows-msvc test suddenly failing ...

@Lokathor
Copy link
Copy Markdown
Owner

Lokathor commented Nov 8, 2025

I think it's the same safe_arch bug that keeps happening. I really have to look in to that.

@KonaeAkira KonaeAkira marked this pull request as ready for review November 26, 2025 17:56
@Lokathor
Copy link
Copy Markdown
Owner

i guess this update is nightly only? since it seems to be enabling a compiler feature.

@KonaeAkira
Copy link
Copy Markdown
Contributor Author

Yes, this is for nightly only. wasm64 doesn't really work outside of nightly right now.

@Lokathor
Copy link
Copy Markdown
Owner

I think it should always be opt-in for a crate to turn on a nightly compiler feature, such as putting a nightly_wasm64 cargo feature into the crate. and with a comment on the cargo feature declaration that it's not part of our stable semver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants