Add support for wasm64 with simd128#233
Open
KonaeAkira wants to merge 8 commits intoLokathor:mainfrom
Open
Conversation
Owner
|
I don't know that the build_check_only pass uses Nightly at all, so you'll probably have to change it to be a Nightly CI pass. |
Contributor
Author
|
Turns out I was looking at the wrong matrix. Thanks :) |
Contributor
Author
|
Huh, why is the |
Owner
|
I think it's the same safe_arch bug that keeps happening. I really have to look in to that. |
Owner
|
i guess this update is nightly only? since it seems to be enabling a compiler feature. |
Contributor
Author
|
Yes, this is for nightly only. |
Owner
|
I think it should always be opt-in for a crate to turn on a nightly compiler feature, such as putting a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even though the
memory64feature has been standardized, thewasm64-unknown-unknowntarget is currently only a tier 3 target, so it's perfectly understandable if you don't want to merge this PR.I stumbled upon this while experimenting with building my project with
wasm64-unknown-unknown.