Skip to content

Fix Process::read_into_uninit_slice Unsoundness #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CryZe merged 1 commit into from
Dec 26, 2025
Merged

Fix Process::read_into_uninit_slice Unsoundness #128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/runtime/process.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,11 +339,11 @@ impl Process {
/// of a specific type. The buffer does not need to be initialized. After
/// the slice successfully got filled, the initialized slice is returned.
#[inline]
pub fn read_into_uninit_slice<T: CheckedBitPattern>(
pub fn read_into_uninit_slice<'buf, T: CheckedBitPattern>(
&self,
address: impl Into<Address>,
slice: &mut [MaybeUninit<T>],
) -> Result<&mut [T], Error> {
slice: &'buf mut [MaybeUninit<T>],
) -> Result<&'buf mut [T], Error> {
// SAFETY: The process handle is guaranteed to be valid. We provide a
// valid pointer and length to the buffer. We also do proper error
// handling afterwards. The buffer is guaranteed to be initialized
Expand Down
Loading