Send server add/remove events to the servers too#11
Open
amaranth wants to merge 1 commit intoLilyPad:masterfrom
Open
Send server add/remove events to the servers too#11amaranth wants to merge 1 commit intoLilyPad:masterfrom
amaranth wants to merge 1 commit intoLilyPad:masterfrom
Conversation
Contributor
|
Perhaps you should send the event to all the authenticated clients connected, not just those rolled as servers. Then custom clients that don't get rolled can make use of the event as well. |
Author
|
Updated to latest master. Not sure about sending it more widely, doesn't really matter to me. I don't know enough about how things work to decide if that would be a good idea. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows bukkit plugins to make use of the ServerAddEvent and ServerRemoveEvent events so they can react appropriately as other servers join and leave the network.