Draft
Conversation
b43ed47 to
860c66d
Compare
Contributor
Author
|
|
nikkolasg
reviewed
Dec 17, 2025
| } | ||
|
|
||
| // Initialize backend if not already done | ||
| init_blitzar_backend(); |
Contributor
There was a problem hiding this comment.
Shouldn't we do it at init time instead of always inside this function ?
dp-crypto/benches/pcs.rs
Outdated
| let (pp, _) = HyperKZG::<Bn254>::test_setup(&mut thread_rng(), N); | ||
| let polys: Vec<ADensePolynomial<Fr>> = (0..batch_size) | ||
| .map(|_| { | ||
| let evals = arkworks_static_evals(2u32.pow(N as u32) as usize); |
Contributor
There was a problem hiding this comment.
Can you check what's the result with random values instead of the static low weight values here ?
Contributor
Author
|
rerun on random data: |
Contributor
Author
|
altogether: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.