GitHub Issue 898: SampleFinder: MVFK over MVTC with special characters result in bad grid#7474
Open
GitHub Issue 898: SampleFinder: MVFK over MVTC with special characters result in bad grid#7474
Conversation
…s result in bad sql error
| { | ||
| String pgArrayStr = strVal.substring(1, strVal.length() - 1); | ||
| // pgArrayStr escapes double quote with \", but MultiChoice.Array.from expects GoogleSheetMultiValue, which escapes quote with double quotes "" | ||
| pgArrayStr = pgArrayStr.replace("\\\"", "\"\""); |
Contributor
There was a problem hiding this comment.
I did not think of this case , needing to parse server-side (CAST mv AS TEXT).
I think it might be better to write a full parsePgArray() method, because if there is one character that is \-escaped there are more. E.g.
SELECT CAST(ARRAY[a,b,c] as VARCHAR)
FROM (VALUES ('a"', 'b\', 'c\"')) AS x (a, b, c)
Contributor
There was a problem hiding this comment.
Maybe we could leave the {} in place and let MultiChoice.Parser detect them and use an alternate parser?
Contributor
Author
There was a problem hiding this comment.
Added parsePgArray method. I only know of double quote and backslash that needs special handling. Let me know if there are more that you know of.
labkey-matthewb
approved these changes
Mar 5, 2026
XingY
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Issue link
When a MultiChoice field contains options that contains double quote character, the field fails to display properly when queried as a multi-value foreign key, such as Ancestor columns for sample finder. This is due to GROUP_CONCAT escapes double quote with \", but MultiChoice.Array.from expects GoogleSheetMultiValue, which escapes quote with double quotes "".
This PR also contains package version update for Issue 897: Study dataset should not allow multivalue text choice as a third key
Related Pull Requests
Changes