Refactor: Remove socketmap handler and thunder integration#305
Conversation
- Deleted handler functions for domain and user existence checks. - Removed netstring protocol handling from the server. - Eliminated Thunder authentication and user validation logic. - Cleaned up related types and utility functions. - Streamlined the main application entry point by removing unnecessary components.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the project's service architecture by eliminating the standalone Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
The socketmap-server service, which provided dynamic virtual mailbox maps for Postfix, has been entirely removed. Its functionality, including configuration, caching, and integration with Thunder IDP for user, domain, and alias lookups, has been absorbed into the raven-server. This change is reflected across docker-compose.yaml where the socketmap-server service definition and related volume mounts are removed, and the raven-server now exposes the socketmap port (9100) and inherits the necessary environment variables and Docker socket mount. The Postfix configuration script (gen-postfix-conf.sh) has been updated to point to raven:9100 for socketmap services, indicating a consolidation of these mail-related functionalities within the raven-server.
📌 Description
This PR is to remove the socketmap service from the silver repo and move it to the raven repo.
🔍 Changes Made
✅ Checklist (Email System)
🧪 Testing Instructions
📷 Screenshots / Logs (if applicable)