Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the Docker build and release process for the project, focusing on improving the Docker image configuration and streamlining the build pipeline. The main changes include introducing a new Dockerfile specifically for GoReleaser, updating the Docker image to use a minimal base image, and ensuring configuration files are included in the final image.
Docker image and build pipeline improvements:
Dockerfile.goreleaserthat uses thegcr.io/distroless/static-debian12:nonrootbase image, copies the probe binary and example config, exposes port 8080, and sets the appropriate entrypoint and command.goreleaser.yamlto use the newDockerfile.goreleaserfor building Docker images, and includedprobe.example.yamlas an extra file in the image for bothamd64andarm64architectures. [1] [2]goreleaser.yamlto usetar.gzformat for both Linux and Darwin targets, ensuring consistent packaging.