Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant enhancements and refactoring to support a new "connected" mode for the probe, clarify configuration, and improve deployment and operational flexibility. The changes unify and clarify the probe modes ("standalone", "connected", "hosted"), update configuration and validation logic, improve Docker and healthcheck support, and add remote endpoint polling for dynamic configuration in connected/hosted modes.
Configuration and Mode Refactoring
internal/config/config.go,.env.example,internal/config/config_test.go,internal/health/health_test.go,internal/reporter/reporter_test.go) [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16].Scheduler and Remote Endpoint Polling
internal/scheduler/scheduler.go) [1] [2].Deployment and Healthcheck Improvements
docker-compose.yamlto simplify deployment: uses.envfor configuration, sets up persistent state directories with correct permissions, exposes the health endpoint, and adds a container healthcheck using a new--healthcheckCLI flag (Dockerfile,docker-compose.yaml,cmd/probe/main.go) [1] [2] [3] [4] [5].CLI and Logging Enhancements
--healthcheckCLI flag to allow scripts and Docker to check probe health easily, and clarifies logging for standalone mode operation (cmd/probe/main.go) [1] [2] [3] [4].Test Suite Updates
internal/config/config_test.go,internal/health/health_test.go,internal/reporter/reporter_test.go) [1] [2] [3] [4] [5] [6].These changes collectively make the probe easier to configure, safer to deploy, and more flexible for both local and managed/connected use cases.