Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces comprehensive support for endpoint monitoring management in the KrakenKey CLI. It adds a new
endpointcommand with multiple subcommands to manage monitored endpoints, including adding, listing, showing, enabling/disabling, deleting endpoints, assigning/removing probes, managing hosted probe regions, and triggering on-demand scans. The implementation includes new API client methods, data types, and command handlers, along with documentation and pre-commit hooks for Go code quality.New Endpoint Monitoring CLI Functionality
endpointcommand to the CLI with subcommands for adding, listing, showing, enabling/disabling, deleting endpoints, managing probes and regions, and requesting scans. This includes user-friendly usage strings and examples in the CLI help output. [1] [2] [3]API Client Enhancements
internal/api/client.go) for endpoint operations: create, list, show, update, delete endpoints, manage regions and probes, and request scans.Data Model Additions
internal/api/types.goto represent endpoints, hosted regions, probes, and probe assignments, supporting the new monitoring features.Command Handlers for Endpoint Operations
internal/endpoint/endpoint.gowith handler functions for all endpoint-related subcommands, encapsulating logic for interacting with the API and formatting CLI output.Developer Tooling
go vetandgo testto enforce code quality and run tests automatically. (.pre-commit-config.yaml)