fix(kpagination): lost highlight of visible pages on pageCount change#2616
Open
fix(kpagination): lost highlight of visible pages on pageCount change#2616
Conversation
schogges
requested review from
a team,
Justineo,
adamdehaven and
jillztom
as code owners
|
|
✅ Deploy Preview for kongponents-sandbox ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
When the pageCount (total items) changes and the current page is higher than the first pages, the component sets the visible pages back to the first pages. Signed-off-by: schogges <24444046+schogges@users.noreply.github.com>
✅ Deploy Preview for kongponents ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
schogges
force-pushed
the
fix/visible-pages_on_new_page-count
branch
from
507a0be to
2442393
Compare
Collaborator
Preview package from this PR in consuming applicationIn consuming application project install preview version of kongponents generated by this PR: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the pageCount (total items) changes and the current page is higher than the first pages, the component sets the visible pages back to the first pages.
I've added a button to the sandbox to randomly update the total count for easier repro. To actually repro just undo the changes in
src/components/KPagination/KPagination.vue. This should then show the first pages only and no active pagination button.