Conversation
c476e00 to
1361c74
Compare
|
GitHub seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
the new <type category="struct" name="VkDeviceCreateInfo">
<member values="VK_STRUCTURE_TYPE_DEVICE_CREATE_INFO"><type>VkStructureType</type> <name>sType</name></member>
<member optional="true">const <type>void</type>* <name>pNext</name></member>
<member optional="true"><type>VkDeviceCreateFlags</type> <name>flags</name></member>
<member optional="true"><type>uint32_t</type> <name>queueCreateInfoCount</name></member>
<member len="queueCreateInfoCount">const <type>VkDeviceQueueCreateInfo</type>* <name>pQueueCreateInfos</name></member>
<member noautovalidity="true" deprecated="unused"><type>uint32_t</type> <name>enabledLayerCount</name></member>
<member noautovalidity="true" deprecated="unused">const <type>char</type>* const* <name>ppEnabledLayerNames</name><comment>Ordered list of layer names to be enabled</comment></member>
<member optional="true"><type>uint32_t</type> <name>enabledExtensionCount</name></member>
<member len="enabledExtensionCount,null-terminated">const <type>char</type>* const* <name>ppEnabledExtensionNames</name></member>
<member optional="true">const <type>VkPhysicalDeviceFeatures</type>* <name>pEnabledFeatures</name></member>
</type>The newly generated header breaks our sample and most Vulkan-Hpp apps like ggml. We should not break API. |
|
A simple if ( name == "ppEnabledLayerNames" )
{
memberData.lenExpressions = { "enabledLayerCount", "null-terminated" };
}could work around the issue for us. But I'm sure this also affects other binding generators. Was
|
cdc4009 to
ffcf314
Compare
Was `"enabledExtensionCount,null-terminated"` before, now it doesn't contain any meta information. We could - either break API - special case `ppEnabledLayerNames` - raise issue upstream
ffcf314 to
5ade86f
Compare
|
I cannot find any specific mention in the changelogs for 1.4.347 that warrants removing the The only part that mentions the relevant deprecated params:
Though I cannot view the internal issue mentioned here myself. The tag should probably be added back upstream in the xml, no? |
5ade86f to
5aefdff
Compare
5aefdff to
5ade86f
Compare
Please close and reopen this PR to trigger the CI!