Context: add new constructor, and check for throw#1171
Merged
Conversation
Contributor
Author
|
Fail due to Sim-SYCL (expected AFAIK) |
gmlueck
reviewed
Jan 14, 2026
TApplencourt
force-pushed
the
context_new_constructor
branch
from
338bbad to
82334df
Compare
gmlueck
reviewed
Jan 14, 2026
keryell
changed the title
gmlueck
approved these changes
Jan 28, 2026
Contributor
Author
|
Thomas: Will disable the new test for SimSycl (or implement it there) |
Contributor
Author
|
(Note to myself: simsycl take super long to run, maybe we forgot to run them in |
Contributor
Author
|
I did it \o/ @bader you can merge at your convenience :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For KhronosGroup/SYCL-Docs#628 and fix #947
(I did add the test for throw because I didn't read the issue...)