Skip to content

Fix precalculate function in buffer_api_common.h#1168

Merged
bader merged 4 commits intoKhronosGroup:mainfrom
0x12CC:fix_buffer_precalculate
Jan 29, 2026
Merged

Fix precalculate function in buffer_api_common.h#1168
bader merged 4 commits intoKhronosGroup:mainfrom
0x12CC:fix_buffer_precalculate

Conversation

@0x12CC
Copy link
Copy Markdown
Contributor

@0x12CC 0x12CC commented Jan 6, 2026

The 2D and 3D specializations of the precalculate helper function have bugs that cause the test_buffer_reinterpret class to create buffers with excessively large ranges. This commit changes the specializations to ensure the buffer range never exceeds the size of the host memory specified by the hostData pointer provided during initialization.

Signed-off-by: Michael Aziz <michael.aziz@intel.com>
@0x12CC 0x12CC requested a review from a team as a code owner January 6, 2026 18:13
Copy link
Copy Markdown
Member

@keryell keryell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Signed-off-by: Michael Aziz <michael.aziz@intel.com>
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
@0x12CC 0x12CC requested a review from bader January 21, 2026 20:35
@bader bader merged commit 1b24163 into KhronosGroup:main Jan 29, 2026
9 checks passed
@0x12CC 0x12CC deleted the fix_buffer_precalculate branch January 29, 2026 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants