Remove duplicate NETL flow correction method#20
Merged
frankhanna94 merged 1 commit intodevelopmentfrom Jan 5, 2026
Merged
Conversation
addresses NETL-RIC#260. Remove duplicate correct_netl_flow_names from natural_gas_upstream.py and update the same method found in elementaryflows.py; cross-check that the data are the same when running fix_coal_mining_lci in coal_upstream.py (PASS); uppercase globals in natural_gas_upstream.py; minor formatting fixes
frankhanna94
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses NETL-RIC#260. It removes the duplicate
correct_netl_flow_namesfrom natural_gas_upstream.py and updates the method of the same name found in elementaryflows.py. As this method is reference infix_coal_mining_lciin coal_upstream.py, the results were cross-checked before and after the updateThe differences between the two dataframes were only in the 'flow_name' column for five rows:
These corrections are based on poor encodings (note the Greek letters) and new mappings.
Global variabless in natural_gas_upstream.py were capitalized to conform with standard.
Minor formatting fixes were applied to conform to PEP8.