Natural Gas Upstream update - Addresses issue #260#16
Merged
dt-woods merged 6 commits intoKeyLogicLCA:developmentfrom Nov 21, 2025
Merged
Natural Gas Upstream update - Addresses issue #260#16dt-woods merged 6 commits intoKeyLogicLCA:developmentfrom
dt-woods merged 6 commits intoKeyLogicLCA:developmentfrom
Conversation
frankhanna94
commented
Oct 16, 2025
frankhanna94
commented
- added ng_model_year parameter to the modelconfig files
- added new function to generate the ng lci based on the ng_model_year parameter
- added NG_MODEL_YEARS to globals.py
- added the ng_model_year to the config files
- minor fix in eia_trans_dist_grid_loss.py
- important note: modified generate_upstream_ng to handle NaN values. See comments in the code.
- added ng_model_year parameter to the modelconfig files
- added new function to generate the ng lci based on the ng_model_year parameter
- added NG_MODEL_YEARS to globals.py
- added the ng_model_year to the config files
- minor fix in eia_trans_dist_grid_loss.py
- important note: modified generate_upstream_ng to handle NaN values.
See comments in the code.
- Updated the 2020 ng model to use the region basis - Implemented additional changes to map eia plants to regions - Updated the code to use basin mapping for 2016 and region basis for 2020 ng model
dt-woods
approved these changes
Nov 21, 2025
dt-woods
left a comment
dt-woods
left a comment
There was a problem hiding this comment.
Cursory review looks good. Will test on acceptance.
31 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.