Updates for ELCI2023 + other minor bug fixes#15
Merged
frankhanna94 merged 2 commits intoKeyLogicLCA:developmentfrom Oct 14, 2025
Merged
Updates for ELCI2023 + other minor bug fixes#15frankhanna94 merged 2 commits intoKeyLogicLCA:developmentfrom
frankhanna94 merged 2 commits intoKeyLogicLCA:developmentfrom
Conversation
- updated egrid_facilities.py to account for FuelCategory column name in new stewi data - updated eia_trans_dist_grid_loss.py to account for new link format for 2023 data
Updated parameter type for 'year' to accept both string and integer. Added type check to convert 'year' to string if passed as an integer. Adjusted DataFrame selection to use double brackets for consistency.
frankhanna94
commented
Oct 14, 2025
Author
frankhanna94
left a comment
frankhanna94
left a comment
There was a problem hiding this comment.
reviewed changes with TWD
31 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1- Updated egrid_facilities.py to account for the fuel category column name in new StEWI data.
2022 and earlier data had a column called 'Plant primary coal/oil/gas/ other fossil fuel category' containing 'Fuel Category' information. Fuel category in new StEWI data falls under 'Plant primary fuel category' column. Changes were made in the code to extract this info in ELCI2023 config.
2- Updated eia_trans_dist_grid_loss.py to account for new link format for 2023 EIA data: both url_a (archive data) and 'url_b' don't work for 2023 data. url_b ended up downloaded 2022 data and failing on new hampshire. i added a new url format that works for 2023 data.